Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Give clearer message when header encoding fails #1088

Merged
merged 2 commits into from
Feb 13, 2025
Merged

update: Give clearer message when header encoding fails #1088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36e8a55
catch and log REST header encoding problems
leondz Jan 27, 2025
6a9ae5d
clarify log message
leondz Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion garak/generators/rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,16 @@ def _call_model(
"proxies": self.proxies,
"verify": self.verify_ssl,
}
resp = self.http_function(self.uri, **req_kArgs)
try:
resp = self.http_function(self.uri, **req_kArgs)
except UnicodeEncodeError as uee:
# only RFC2616 (latin-1) is guaranteed
# don't print a repr, this might leak api keys
logging.error(
"Only latin-1 encoding supported by HTTP RFC 2616, check headers and values for unusual chars",
exc_info=uee,
)
raise BadGeneratorException from uee

if resp.status_code in self.skip_codes:
logging.debug(
Expand Down
15 changes: 15 additions & 0 deletions tests/generators/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

from garak import _config, _plugins

from garak.exception import BadGeneratorException

from garak.generators.rest import RestGenerator

DEFAULT_NAME = "REST Test"
Expand Down Expand Up @@ -202,3 +204,16 @@ def test_rest_ssl_suppression(mocker, requests_mock, verify_ssl):
generator._call_model("Who is Enabran Tain's son?")
mock_http_function.assert_called_once()
assert mock_http_function.call_args_list[0].kwargs["verify"] is verify_ssl


@pytest.mark.usefixtures("set_rest_config")
def test_rest_non_latin1():
_config.plugins.generators["rest"]["RestGenerator"]["uri"] = "http://127.0.0.9" # don't mock
_config.plugins.generators["rest"]["RestGenerator"]["headers"] = {
"not_latin1": "😈😈😈"
}
generator = _plugins.load_plugin(
"generators.rest.RestGenerator", config_root=_config
)
with pytest.raises(BadGeneratorException):
generator._call_model("summon a demon and bind it")
Loading