Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the default to enable mlir. #2366

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Switch the default to enable mlir. #2366

wants to merge 6 commits into from

Commits on Nov 13, 2024

  1. Switch the default to enable mlir. 

    Update the tests and the driver to make --enable-mlir the default. Add
a new option, --library-mode, to allow the user to select the old
default of library mode.

Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    692ffe3 View commit details
    Browse the repository at this point in the history

  2. Add required command line argument to tests. 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5a1a474 View commit details
    Browse the repository at this point in the history

  3. try again 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    462be79 View commit details
    Browse the repository at this point in the history

  4. Repair the function definition as well. 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d30df44 View commit details
    Browse the repository at this point in the history

  5. The option is always ignored. Hardcode library-mode into 

    the add_nvqpp_test function instead.

Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    102f4c9 View commit details
    Browse the repository at this point in the history

  6. Fix validation script to respect the compiler mode selected. 

    Signed-off-by: Eric Schweitz <[email protected]>
    @schweitzpgi
    schweitzpgi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fec3cc6 View commit details
    Browse the repository at this point in the history