Skip to content

Add Buffer.release() #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add Buffer.release() #649

wants to merge 1 commit into from

Conversation

leofang
Copy link
Member

@leofang leofang commented May 20, 2025

Description

closes #567

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang added this to the cuda-python 12-next, 11-next milestone May 20, 2025
@leofang leofang self-assigned this May 20, 2025
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module labels May 20, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented May 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented May 20, 2025

cc @realarnavgoel for vis

@leofang
Copy link
Member Author

leofang commented May 21, 2025

/ok to test 3759515

@github-actions GitHub Actions
Copy link

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-649/

https://nvidia.github.io/cuda-python/pr-preview/pr-649/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-649/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@rwgk
Copy link
Collaborator

rwgk commented May 22, 2025

I reviewed the code like this (I believe it is very focused):

https://chatgpt.com/share/682eaa73-b94c-8008-a662-936ac6a1aaac

Suggestion to go through that chat together tomorrow in our design meeting.

@oleksandr-pavlyk for visibility (based on the discussion we had in our sync-up meeting yesterday).

@rwgk rwgk mentioned this pull request May 22, 2025
Open
1 task
@leofang
Copy link
Member Author

leofang commented May 23, 2025

We discussed and decided to put this PR on hold, see #567 (comment). The nvshmem4py team reported a finalizer-related issue, but it seems unrelated to the need of this PR. We'll help debug.

@leofang leofang marked this pull request as draft May 23, 2025 23:03
@leofang leofang added triage Needs the team's attention and removed P0 High priority - Must do! labels May 30, 2025
@leofang leofang removed this from the cuda-python 12-next, 11-next milestone May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk Awaiting requested review from rwgk

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

@kkraus14 kkraus14 Awaiting requested review from kkraus14

At least 1 approving review is required to merge this pull request.

Assignees

@leofang leofang

Labels
cuda.core Everything related to the cuda.core module feature New feature or request triage Needs the team's attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Add a release() method to cuda.core.Buffer to side-step the Python garbage collector
2 participants
@leofang @rwgk