Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation struct getters #413

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Jan 23, 2025

Add a note about using the getters and setters directly to avoid implementation details which break common pythonic code patterns

close #262

Copy link
Contributor

copy-pr-bot bot commented Jan 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work ksimpson-work self-assigned this Jan 23, 2025
@ksimpson-work ksimpson-work added documentation Improvements or additions to documentation enhancement Any code-related improvements cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do! labels Jan 23, 2025
@ksimpson-work
Copy link
Contributor Author

/ok to test

This comment has been minimized.

@ksimpson-work ksimpson-work marked this pull request as ready for review January 23, 2025 22:15
@leofang leofang requested review from rwgk and removed request for leofang January 24, 2025 02:10
@ksimpson-work
Copy link
Contributor Author

/ok to test

rwgk
rwgk previously approved these changes Jan 24, 2025
cuda_bindings/docs/source/tips_and_tricks.rst Outdated Show resolved Hide resolved
cuda_bindings/docs/source/tips_and_tricks.rst Outdated Show resolved Hide resolved
cuda_bindings/docs/source/tips_and_tricks.rst Outdated Show resolved Hide resolved
@leofang
Copy link
Member

leofang commented Jan 24, 2025

Admin-merge during release meeting, proceed to #366.

@leofang leofang merged commit cf9d560 into NVIDIA:main Jan 24, 2025
1 check passed
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
3 participants