Add exception manager to handle options which aren't covered in all CTK versions #371
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksimpson-work
added
P1
|
/ok to test |
Draft
|
/ok to test |
leofang
reviewed
Jan 15, 2025
Comment on lines
+49
to
+50
| if culink_backend: | ||
| return |
There was a problem hiding this comment.
I actually don't know the behavior of return in a function decorated by contextmanager. I don't think the semantics is documented? Perhaps this is what you are after?
if not culink_backend:
skip_version_specific_linker_options = ... # this decorated function, but without the return
else:
skip_version_specific_linker_options = nullcontexthttps://docs.python.org/3/library/contextlib.html#contextlib.nullcontext
leofang
reviewed
Jan 15, 2025
Comment on lines
+53
to
+55
| except nvjitlink.nvJitLinkError as e: | ||
| if e.status == nvjitlink.Result.ERROR_UNRECOGNIZED_OPTION: | ||
| pytest.skip("current nvjitlink version does not support the option provided") |
There was a problem hiding this comment.
- this probably needs a reraise when the error code is not unrecognized option:
Suggested change
| except nvjitlink.nvJitLinkError as e: | |
| if e.status == nvjitlink.Result.ERROR_UNRECOGNIZED_OPTION: | |
| pytest.skip("current nvjitlink version does not support the option provided") | |
| except nvjitlink.nvJitLinkError as e: | |
| if e.status == nvjitlink.Result.ERROR_UNRECOGNIZED_OPTION: | |
| pytest.skip("current nvjitlink version does not support the option provided") | |
| else: | |
| raise |
- I am wondering if this check should be moved to
_exception_manager()in_linker.py? WDYT?
leofang
reviewed
Jan 15, 2025
Comment on lines
+56
to
+57
| except Exception as e: | ||
| raise e |
There was a problem hiding this comment.
this can be removed entirely
Suggested change
| except Exception as e: | |
| raise e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change skips tests when a specific nvjitlink exception is raised for invalid option, which happens if the option is invalid, or if the option is invalid for the given CTK.
I think we should also add cuda 12.4 to the test matrix because <21.3 targets the culink backend, and cuda 12.6 has options which aren't part of 12.4