Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assorted bug fixes for the std::execution implementation in cudax #3721

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ericniebler
Copy link
Contributor

@ericniebler ericniebler commented Feb 6, 2025

Description

assorted fixes for ustdex issues i found while prototyping the cudax async model. this PR fixes:

  • missing deduction guides for prop and __rcvr_with_env_t
  • bad diagnostics from sync_wait for senders that fail type-checking
  • lack of sync_wait overload that takes an environment
  • __decay_copy isn't decaying lvalues
  • needless duplication of cuda::std::__ignore_t
  • reversed args when constructing the operation state of write_env

@ericniebler ericniebler requested a review from a team as a code owner February 6, 2025 18:20
@ericniebler ericniebler requested a review from pciolkosz February 6, 2025 18:20
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🟩 CI finished in 19m 04s: Pass: 100%/20 | Total: 2h 06m | Avg: 6m 20s | Max: 12m 45s | Hits: 85%/10080
  • 🟩 cudax: Pass: 100%/20 | Total: 2h 06m | Avg: 6m 20s | Max: 12m 45s | Hits: 85%/10080

    🟩 cpu
      🟩 amd64              Pass: 100%/16  | Total:  1h 50m | Avg:  6m 54s | Max: 12m 45s | Hits:  85%/7868  
      🟩 arm64              Pass: 100%/4   | Total: 16m 12s | Avg:  4m 03s | Max:  4m 14s | Hits:  87%/2212  
    🟩 ctk
      🟩 12.0               Pass: 100%/1   | Total: 11m 27s | Avg: 11m 27s | Max: 11m 27s | Hits:  58%/261   
      🟩 12.5               Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max:  8m 45s | Hits:  60%/706   
      🟩 12.8               Pass: 100%/17  | Total:  1h 38m | Avg:  5m 46s | Max: 12m 45s | Hits:  88%/9113  
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/1   | Total: 11m 27s | Avg: 11m 27s | Max: 11m 27s | Hits:  58%/261   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max:  8m 45s | Hits:  60%/706   
      🟩 nvcc12.8           Pass: 100%/17  | Total:  1h 38m | Avg:  5m 46s | Max: 12m 45s | Hits:  88%/9113  
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/20  | Total:  2h 06m | Avg:  6m 20s | Max: 12m 45s | Hits:  85%/10080 
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  4m 36s | Avg:  4m 36s | Max:  4m 36s | Hits:  88%/555   
      🟩 Clang15            Pass: 100%/1   | Total:  4m 36s | Avg:  4m 36s | Max:  4m 36s | Hits:  88%/553   
      🟩 Clang16            Pass: 100%/1   | Total:  5m 04s | Avg:  5m 04s | Max:  5m 04s | Hits:  88%/553   
      🟩 Clang17            Pass: 100%/1   | Total:  4m 55s | Avg:  4m 55s | Max:  4m 55s | Hits:  88%/553   
      🟩 Clang18            Pass: 100%/4   | Total: 24m 41s | Avg:  6m 10s | Max: 11m 48s | Hits:  90%/2212  
      🟩 GCC10              Pass: 100%/1   | Total:  4m 29s | Avg:  4m 29s | Max:  4m 29s | Hits:  87%/555   
      🟩 GCC11              Pass: 100%/1   | Total:  4m 54s | Avg:  4m 54s | Max:  4m 54s | Hits:  87%/553   
      🟩 GCC12              Pass: 100%/2   | Total: 17m 29s | Avg:  8m 44s | Max: 12m 45s | Hits:  93%/1106  
      🟩 GCC13              Pass: 100%/4   | Total: 16m 17s | Avg:  4m 04s | Max:  4m 14s | Hits:  87%/2212  
      🟩 MSVC14.39          Pass: 100%/1   | Total: 11m 27s | Avg: 11m 27s | Max: 11m 27s | Hits:  58%/261   
      🟩 MSVC14.42          Pass: 100%/1   | Total: 11m 05s | Avg: 11m 05s | Max: 11m 05s | Hits:  58%/261   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max:  8m 45s | Hits:  60%/706   
    🟩 cxx_family
      🟩 Clang              Pass: 100%/8   | Total: 43m 52s | Avg:  5m 29s | Max: 11m 48s | Hits:  89%/4426  
      🟩 GCC                Pass: 100%/8   | Total: 43m 09s | Avg:  5m 23s | Max: 12m 45s | Hits:  89%/4426  
      🟩 MSVC               Pass: 100%/2   | Total: 22m 32s | Avg: 11m 16s | Max: 11m 27s | Hits:  58%/522   
      🟩 NVHPC              Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max:  8m 45s | Hits:  60%/706   
    🟩 gpu
      🟩 rtx2080            Pass: 100%/20  | Total:  2h 06m | Avg:  6m 20s | Max: 12m 45s | Hits:  85%/10080 
    🟩 jobs
      🟩 Build              Pass: 100%/18  | Total:  1h 42m | Avg:  5m 40s | Max: 11m 27s | Hits:  83%/8974  
      🟩 Test               Pass: 100%/2   | Total: 24m 33s | Avg: 12m 16s | Max: 12m 45s | Hits:  99%/1106  
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  3m 49s | Avg:  3m 49s | Max:  3m 49s | Hits:  87%/553   
      🟩 90a                Pass: 100%/1   | Total:  4m 13s | Avg:  4m 13s | Max:  4m 13s | Hits:  87%/553   
    🟩 std
      🟩 17                 Pass: 100%/4   | Total: 20m 05s | Avg:  5m 01s | Max:  8m 30s | Hits:  83%/2012  
      🟩 20                 Pass: 100%/16  | Total:  1h 46m | Avg:  6m 40s | Max: 12m 45s | Hits:  86%/8068  
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 20)

# Runner
12 linux-amd64-cpu16
4 linux-arm64-cpu16
2 windows-amd64-cpu16
2 linux-amd64-gpu-rtx2080-latest-1

@ericniebler ericniebler merged commit 0d6ab79 into NVIDIA:main Feb 6, 2025
36 of 38 checks passed
@ericniebler ericniebler deleted the cudax-ustdex-fixes branch February 6, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants