Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups following bool-to-enum template parameter PR #3716

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Minor cleanups following bool-to-enum template parameter PR #3716

merged 1 commit into from
Feb 6, 2025

Conversation

elstehle
Copy link
Collaborator

@elstehle elstehle commented Feb 6, 2025

Description

Following #3643 there were few final minor review comments for which I didn't want to run CI on the full PR again. This PR addresses those comments.

@elstehle elstehle requested a review from a team as a code owner February 6, 2025 14:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🟩 CI finished in 1h 08m: Pass: 100%/90 | Total: 15h 29m | Avg: 10m 19s | Max: 34m 52s | Hits: 94%/132225

  • 🟩 cub: Pass: 100%/44 | Total: 8h 09m | Avg: 11m 07s | Max: 33m 25s | Hits: 93%/52320 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  7h 58m | Avg: 11m 23s | Max: 33m 25s | Hits:  92%/49888 
  🟩 arm64              Pass: 100%/2   | Total: 10m 55s | Avg:  5m 27s | Max:  5m 48s | Hits:  99%/2432  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 51m 49s | Avg: 10m 21s | Max: 29m 07s | Hits:  85%/5914  
  🟩 12.5               Pass: 100%/2   | Total: 20m 38s | Avg: 10m 19s | Max: 10m 31s | Hits:  98%/2250  
  🟩 12.8               Pass: 100%/37  | Total:  6h 57m | Avg: 11m 16s | Max: 33m 25s | Hits:  93%/44156 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  5m 07s | Hits: 100%/2104  
  🟩 nvcc12.0           Pass: 100%/5   | Total: 51m 49s | Avg: 10m 21s | Max: 29m 07s | Hits:  85%/5914  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 20m 38s | Avg: 10m 19s | Max: 10m 31s | Hits:  98%/2250  
  🟩 nvcc12.8           Pass: 100%/35  | Total:  6h 47m | Avg: 11m 38s | Max: 33m 25s | Hits:  93%/42052 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 52s | Avg:  4m 56s | Max:  5m 07s | Hits: 100%/2104  
  🟩 nvcc               Pass: 100%/42  | Total:  7h 59m | Avg: 11m 25s | Max: 33m 25s | Hits:  92%/50216 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 23m 02s | Avg:  5m 45s | Max:  5m 58s | Hits: 100%/4872  
  🟩 Clang15            Pass: 100%/2   | Total: 12m 18s | Avg:  6m 09s | Max:  6m 10s | Hits: 100%/2432  
  🟩 Clang16            Pass: 100%/2   | Total: 12m 06s | Avg:  6m 03s | Max:  6m 21s | Hits: 100%/2432  
  🟩 Clang17            Pass: 100%/2   | Total: 12m 05s | Avg:  6m 02s | Max:  6m 10s | Hits: 100%/2432  
  🟩 Clang18            Pass: 100%/7   | Total:  1h 11m | Avg: 10m 11s | Max: 23m 29s | Hits: 100%/8184  
  🟩 GCC7               Pass: 100%/2   | Total: 11m 24s | Avg:  5m 42s | Max:  5m 58s | Hits:  99%/2436  
  🟩 GCC8               Pass: 100%/1   | Total:  6m 06s | Avg:  6m 06s | Max:  6m 06s | Hits:  99%/1218  
  🟩 GCC9               Pass: 100%/2   | Total: 12m 13s | Avg:  6m 06s | Max:  6m 16s | Hits:  99%/2436  
  🟩 GCC10              Pass: 100%/2   | Total: 13m 17s | Avg:  6m 38s | Max:  6m 40s | Hits:  99%/2436  
  🟩 GCC11              Pass: 100%/2   | Total: 13m 42s | Avg:  6m 51s | Max:  6m 54s | Hits:  99%/2432  
  🟩 GCC12              Pass: 100%/2   | Total: 13m 01s | Avg:  6m 30s | Max:  6m 37s | Hits:  99%/2432  
  🟩 GCC13              Pass: 100%/10  | Total:  2h 23m | Avg: 14m 21s | Max: 25m 49s | Hits:  99%/12160 
  🟩 MSVC14.29          Pass: 100%/2   | Total: 58m 47s | Avg: 29m 23s | Max: 29m 40s | Hits:  16%/2084  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 06m | Avg: 33m 06s | Max: 33m 25s | Hits:  16%/2084  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 20m 38s | Avg: 10m 19s | Max: 10m 31s | Hits:  98%/2250  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 10m | Avg:  7m 41s | Max: 23m 29s | Hits: 100%/20352 
  🟩 GCC                Pass: 100%/21  | Total:  3h 33m | Avg: 10m 09s | Max: 25m 49s | Hits:  99%/25550 
  🟩 MSVC               Pass: 100%/4   | Total:  2h 05m | Avg: 31m 15s | Max: 33m 25s | Hits:  16%/4168  
  🟩 NVHPC              Pass: 100%/2   | Total: 20m 38s | Avg: 10m 19s | Max: 10m 31s | Hits:  98%/2250  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 30m 04s | Avg: 15m 02s | Max: 25m 01s | Hits:  99%/2432  
  🟩 rtx2080            Pass: 100%/34  | Total:  5h 15m | Avg:  9m 16s | Max: 33m 25s | Hits:  91%/40160 
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 24m | Avg: 18m 02s | Max: 25m 49s | Hits:  99%/9728  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 32m | Avg:  8m 59s | Max: 33m 25s | Hits:  91%/43808 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 21m 08s | Avg: 21m 08s | Max: 21m 08s | Hits:  99%/1216  
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 11s | Avg: 18m 11s | Max: 18m 11s | Hits:  99%/1216  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 14m | Avg: 24m 46s | Max: 25m 49s | Hits:  99%/3648  
  🟩 TestGPU            Pass: 100%/2   | Total: 43m 06s | Avg: 21m 33s | Max: 22m 06s | Hits:  99%/2432  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 30m 04s | Avg: 15m 02s | Max: 25m 01s | Hits:  99%/2432  
  🟩 90;90a;100         Pass: 100%/1   | Total:  7m 10s | Avg:  7m 10s | Max:  7m 10s | Hits:  99%/1216  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 20m | Avg: 10m 00s | Max: 33m 25s | Hits:  88%/23559 
  🟩 20                 Pass: 100%/24  | Total:  4h 49m | Avg: 12m 03s | Max: 32m 48s | Hits:  96%/28761

  • 🟩 thrust: Pass: 100%/43 | Total: 6h 40m | Avg: 9m 18s | Max: 34m 52s | Hits: 96%/79625 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 50s | Avg:  8m 55s | Max: 11m 20s | Hits:  99%/3706  
🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total:  6h 30m | Avg:  9m 30s | Max: 34m 52s | Hits:  95%/75920 
  🟩 arm64              Pass: 100%/2   | Total: 10m 06s | Avg:  5m 03s | Max:  5m 22s | Hits:  99%/3705  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 46m 40s | Avg:  9m 20s | Max: 25m 14s | Hits:  93%/9256  
  🟩 12.5               Pass: 100%/2   | Total: 29m 10s | Avg: 14m 35s | Max: 14m 37s | Hits:  99%/3704  
  🟩 12.8               Pass: 100%/36  | Total:  5h 24m | Avg:  9m 00s | Max: 34m 52s | Hits:  96%/66665 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 58s | Avg:  5m 29s | Max:  5m 34s | Hits: 100%/3704  
  🟩 nvcc12.0           Pass: 100%/5   | Total: 46m 40s | Avg:  9m 20s | Max: 25m 14s | Hits:  93%/9256  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 29m 10s | Avg: 14m 35s | Max: 14m 37s | Hits:  99%/3704  
  🟩 nvcc12.8           Pass: 100%/34  | Total:  5h 13m | Avg:  9m 13s | Max: 34m 52s | Hits:  95%/62961 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 58s | Avg:  5m 29s | Max:  5m 34s | Hits: 100%/3704  
  🟩 nvcc               Pass: 100%/41  | Total:  6h 29m | Avg:  9m 29s | Max: 34m 52s | Hits:  95%/75921 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 55s | Avg:  5m 28s | Max:  6m 00s | Hits: 100%/7408  
  🟩 Clang15            Pass: 100%/2   | Total: 11m 42s | Avg:  5m 51s | Max:  5m 58s | Hits: 100%/3704  
  🟩 Clang16            Pass: 100%/2   | Total: 11m 02s | Avg:  5m 31s | Max:  5m 40s | Hits: 100%/3704  
  🟩 Clang17            Pass: 100%/2   | Total: 10m 58s | Avg:  5m 29s | Max:  5m 37s | Hits: 100%/3704  
  🟩 Clang18            Pass: 100%/7   | Total: 45m 23s | Avg:  6m 29s | Max: 10m 24s | Hits: 100%/12964 
  🟩 GCC7               Pass: 100%/2   | Total: 10m 31s | Avg:  5m 15s | Max:  5m 28s | Hits:  99%/3706  
  🟩 GCC8               Pass: 100%/1   | Total:  5m 41s | Avg:  5m 41s | Max:  5m 41s | Hits:  99%/1853  
  🟩 GCC9               Pass: 100%/2   | Total: 11m 36s | Avg:  5m 48s | Max:  5m 48s | Hits:  99%/3706  
  🟩 GCC10              Pass: 100%/2   | Total: 12m 37s | Avg:  6m 18s | Max:  6m 23s | Hits:  99%/3706  
  🟩 GCC11              Pass: 100%/2   | Total: 14m 42s | Avg:  7m 21s | Max:  8m 41s | Hits:  92%/3706  
  🟩 GCC12              Pass: 100%/2   | Total: 12m 31s | Avg:  6m 15s | Max:  6m 34s | Hits:  99%/3706  
  🟩 GCC13              Pass: 100%/8   | Total:  1h 03m | Avg:  7m 59s | Max: 11m 44s | Hits:  99%/14824 
  🟩 MSVC14.29          Pass: 100%/2   | Total: 49m 31s | Avg: 24m 45s | Max: 25m 14s | Hits:  69%/3692  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  1h 29m | Avg: 29m 40s | Max: 34m 52s | Hits:  69%/5538  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 29m 10s | Avg: 14m 35s | Max: 14m 37s | Hits:  99%/3704  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 41m | Avg:  5m 56s | Max: 10m 24s | Hits: 100%/31484 
  🟩 GCC                Pass: 100%/19  | Total:  2h 11m | Avg:  6m 55s | Max: 11m 44s | Hits:  99%/35207 
  🟩 MSVC               Pass: 100%/5   | Total:  2h 18m | Avg: 27m 42s | Max: 34m 52s | Hits:  69%/9230  
  🟩 NVHPC              Pass: 100%/2   | Total: 29m 10s | Avg: 14m 35s | Max: 14m 37s | Hits:  99%/3704  
🟩 gpu
  🟩 rtx2080            Pass: 100%/33  | Total:  4h 28m | Avg:  8m 07s | Max: 26m 39s | Hits:  96%/61112 
  🟩 rtx4090            Pass: 100%/10  | Total:  2h 12m | Avg: 13m 12s | Max: 34m 52s | Hits:  93%/18513 
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  5h 15m | Avg:  8m 30s | Max: 27m 29s | Hits:  96%/68516 
  🟩 TestCPU            Pass: 100%/3   | Total: 51m 41s | Avg: 17m 13s | Max: 34m 52s | Hits:  89%/5551  
  🟩 TestGPU            Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 11m 44s | Hits:  99%/5558  
🟩 sm
  🟩 90;90a;100         Pass: 100%/1   | Total:  6m 36s | Avg:  6m 36s | Max:  6m 36s | Hits:  99%/1853  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 02m | Avg:  9m 06s | Max: 26m 39s | Hits:  95%/37031 
  🟩 20                 Pass: 100%/21  | Total:  3h 20m | Avg:  9m 31s | Max: 34m 52s | Hits:  96%/38888

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 11m 16s | Avg: 5m 38s | Max: 9m 08s | Hits: 98%/280 

    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 11m 16s | Avg:  5m 38s | Max:  9m 08s | Hits:  98%/280   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 08s | Avg:  2m 08s | Max:  2m 08s | Hits:  98%/140   
  🟩 Test               Pass: 100%/1   | Total:  9m 08s | Avg:  9m 08s | Max:  9m 08s | Hits:  98%/140

  • 🟩 python: Pass: 100%/1 | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 28m 10s | Avg: 28m 10s | Max: 28m 10s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 90)
# Runner
65 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1
1 linux-amd64-gpu-h100-latest-1

@elstehle elstehle enabled auto-merge (squash) February 6, 2025 16:14
@elstehle elstehle merged commit 2ca8f90 into NVIDIA:main Feb 6, 2025
103 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

@miscco miscco miscco approved these changes

@gevtushenko gevtushenko Awaiting requested review from gevtushenko gevtushenko is a code owner automatically assigned from NVIDIA/cccl-cub-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elstehle @bernhardmgruber @miscco