-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internalize cuda/detail/core/* #3505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
added
thrust
For all items related to Thrust.
breaking
Breaking change
labels
Jan 23, 2025
miscco
approved these changes
Jan 23, 2025
miscco
approved these changes
Jan 24, 2025
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
from
January 26, 2025 20:14
56f56d1
to
2bb84eb
Compare
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
2 times, most recently
from
January 28, 2025 15:23
3f99dcf
to
866286b
Compare
@gevtushenko does any of the entities in |
elstehle
approved these changes
Jan 28, 2025
🟨 CI finished in 4h 01m: Pass: 98%/89 | Total: 2d 06h | Avg: 36m 28s | Max: 1h 05m | Hits: 418%/10928
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
8 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
from
January 29, 2025 16:40
866286b
to
b733aaf
Compare
bernhardmgruber
changed the title
Internalize cuda/detail/core/util.h
Internalize cuda/detail/core/*
Jan 29, 2025
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
from
January 29, 2025 17:36
b733aaf
to
3085199
Compare
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
from
January 29, 2025 17:38
3085199
to
5d729b2
Compare
🟨 CI finished in 2h 57m: Pass: 98%/89 | Total: 1d 08h | Avg: 21m 52s | Max: 58m 40s | Hits: 402%/10936
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
8 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1 |
bernhardmgruber
force-pushed
the
ref_core_cub_util
branch
from
January 29, 2025 21:41
5d729b2
to
f6a51f5
Compare
🟩 CI finished in 5h 43m: Pass: 100%/89 | Total: 2d 17h | Avg: 43m 55s | Max: 1h 45m | Hits: 199%/10936
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 89)
# | Runner |
---|---|
65 | linux-amd64-cpu16 |
11 | linux-amd64-gpu-v100-latest-1 |
8 | windows-amd64-cpu16 |
4 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1 |
bernhardmgruber
added a commit
to bernhardmgruber/cccl
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all content of
thrust/system/cuda/detail/core/util.h
into a detail namespace. This is a breaking change.Does any of the changes here require a deprecation to be backported?