Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter axis values in perf analysis #1304

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Filter axis values in perf analysis #1304

merged 1 commit into from
Jan 20, 2024

Conversation

gevtushenko
Copy link
Collaborator

Description

closes #1303

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gevtushenko gevtushenko requested a review from a team as a code owner January 19, 2024 22:23
@gevtushenko gevtushenko requested a review from miscco January 19, 2024 22:23
miscco
miscco approved these changes Jan 20, 2024
View reviewed changes
benchmarks/scripts/analyze.py
@@ -215,6 +215,12 @@ def iterate_case_dfs(args, callable):

pattern = re.compile(args.R)

exact_values = {}
if args.args:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be sure will that also catch -a or only --args

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That catches -a

@gevtushenko gevtushenko merged commit bc7b000 into NVIDIA:main Jan 20, 2024
540 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Allow filtering axis values in perf analysis
2 participants
@gevtushenko @miscco