Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-opens Conda-Based Compatibility Test Images #518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Re-opens Conda-Based Compatibility Test Images #518

wants to merge 1 commit into from

Conversation

skothenhill-nv
Copy link
Collaborator

@malcolmgreaves @skothenhill-nv
Initial compatibility testing images (#438)
4881b7c 
Conda-Based Compatibility Test Images (#507)
New `conda` based compatibility test images. Customized CUDA installation via `conda` and `-c nvidia` & `-c pytorch` channels.
Instructions on compatibility image build (#512)
Formatting (#513)
skothenhill-nv
skothenhill-nv commented Dec 9, 2024
View reviewed changes
sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py
Comment on lines +627 to +628
if not check_current_gpu_supports_ampere():
stack.enter_context(torch.cuda.amp.autocast(dtype=torch.float16))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails finetuning tests

skothenhill-nv
skothenhill-nv commented Dec 9, 2024
View reviewed changes
sub-packages/bionemo-core/src/bionemo/core/utils/gpu.py
Comment on lines +66 to +74
check_supports,
(
"A100",
"A6000",
"RTX 30",
"RTX 40",
"A30",
"A40",
),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this is comprehensive of bf16 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstjohn jstjohn Awaiting requested review from jstjohn jstjohn is a code owner

@malcolmgreaves malcolmgreaves Awaiting requested review from malcolmgreaves malcolmgreaves is a code owner

@DejunL DejunL Awaiting requested review from DejunL DejunL is a code owner

@dorotat-nv dorotat-nv Awaiting requested review from dorotat-nv dorotat-nv is a code owner

@farhadrgh farhadrgh Awaiting requested review from farhadrgh farhadrgh is a code owner

@guoqing-zhou guoqing-zhou Awaiting requested review from guoqing-zhou guoqing-zhou is a code owner

@pstjohn pstjohn Awaiting requested review from pstjohn pstjohn is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@malcolmgreaves malcolmgreaves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skothenhill-nv @malcolmgreaves