Polinabinder/file extend #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: polinabinder1 <[email protected]>
Signed-off-by: polinabinder1 <[email protected]>
|
This PR enables concatenation of multiple single cell memory map datasets without copying the full files over and needing to double the memory usage on disk. In this approach, the row, column, and data arrays are copied over in blocks of bytes, and files are deleted after they are copied over, ensuring limits on the amount of data stored in duplicate on disk. |
polinabinder1
requested review from
savitha-eng,
pstjohn,
edawson and
trvachov
polinabinder1
requested review from
jstjohn,
malcolmgreaves and
skothenhill-nv
as code owners
|
/build-ci |
skothenhill-nv
approved these changes
Nov 26, 2024
sub-packages/bionemo-scdl/src/bionemo/scdl/io/single_cell_collection.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/src/bionemo/scdl/io/single_cell_collection.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/src/bionemo/scdl/io/single_cell_memmap_dataset.py
Show resolved
Hide resolved
sub-packages/bionemo-scdl/src/bionemo/scdl/util/filecopyutil.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/tests/bionemo/scdl/io/test_single_cell_memmap_dataset.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/tests/bionemo/scdl/io/test_single_cell_memmap_dataset.py
Outdated
Show resolved
Hide resolved
…ll_memmap_dataset.py Co-authored-by: Steven Kothen-Hill <[email protected]> Signed-off-by: polinabinder1 <[email protected]>
…ll_memmap_dataset.py Co-authored-by: Steven Kothen-Hill <[email protected]> Signed-off-by: polinabinder1 <[email protected]>
|
/build-ci |
edawson
reviewed
Nov 26, 2024
sub-packages/bionemo-scdl/src/bionemo/scdl/io/single_cell_collection.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/tests/bionemo/scdl/io/test_single_cell_memmap_dataset.py
Show resolved
Hide resolved
|
/build-ci |
|
/build-ci |
1 similar comment
|
/build-ci |
edawson
approved these changes
Nov 27, 2024
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.