Add a utility function for extending a file with the content of another file. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edawson
requested review from
jstjohn,
malcolmgreaves,
polinabinder1 and
skothenhill-nv
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new fileutil module that includes a single function (
extend) which extends a file with the content of a second file. @polinabinder1 @savitha-eng and I are using this to reduce the disk usage by a factor of ~2 when using the H5AD -> SCDL conversion script on many H5AD files.Details
The extend function takes in string paths to two files (standard OS files) and extends the first file with the contents of the second. It does not return. The first file is modified in place.
Usage
Currently, this is not user-facing code.
Testing
Currently, tested locally. @polinabinder1 @savitha-eng to add tests.