Fix incorrect types for WandbConfig #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update stop and go to include learning rate check.
…/nemo-run-explore
…ntrypoint for rerunning an experiment. Created an 'ExposedGeneformerConfig' to get around serialization errors with nemo run.
…/nemo-run-explore
instead of discriminated unions we will use GenericModels built into pydantic. Upside is we dont need to know all the variants at parse time, downside is we need to declare the concrete types at parse time.
…recipe reorganizes recipes, configs, and entrypoints.
creates a new recipe to distinguish finetuning/pretraining (but is not exposed)
…ork into hillst/pydantic-ux
…to hillst/pydantic-ux
…to hillst/pydantic-ux
skothenhill-nv
requested review from
farhadrgh,
dorotat-nv,
jstjohn,
malcolmgreaves and
pstjohn
as code owners
|
/build-ci |
…to hillst/wandbconfig_fix
|
/build-ci |
farhadrgh
approved these changes
Nov 7, 2024
jstjohn
approved these changes
Nov 8, 2024
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the config by setting optional fields to actually be optional.