Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH200 support #369

Merged
merged 24 commits into from
Dec 10, 2024
Merged

GH200 support #369

merged 24 commits into from
Dec 10, 2024

Conversation

gagank1
Copy link
Collaborator

@gagank1 gagank1 commented Oct 28, 2024

Adds support for GH200 machines.

Summary

Most of the differences between Dockerfile.arm and Dockerfile involve building packages that are either not available on ARM or don't work for some reason the way they are available on ARM.

Usage

Usage is the same as the normal framework container. It will build and run on GH200 machines now.

Testing

All the existing tests pass on GH200 machines (except for this known bug which results in 1 failure).

Tests for these changes can be run via:
./ci/scripts/run_pytest.sh

@gagank1 gagank1 marked this pull request as ready for review December 9, 2024 07:39
@gagank1 gagank1 requested review from yzhang123 and trvachov December 9, 2024 07:41
@gagank1 gagank1 changed the title Draft: GH200 support GH200 support Dec 9, 2024
@gagank1 gagank1 self-assigned this Dec 9, 2024
Copy link
Collaborator

@trvachov trvachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I asked a few questions to just understand where things are coming from. Thanks!

Dockerfile.arm Show resolved Hide resolved
Dockerfile.arm Show resolved Hide resolved
Dockerfile.arm Show resolved Hide resolved
Dockerfile.arm Show resolved Hide resolved
Dockerfile.arm Show resolved Hide resolved
Dockerfile.arm Outdated Show resolved Hide resolved
Dockerfile.arm Outdated Show resolved Hide resolved
@gagank1 gagank1 removed the request for review from yzhang123 December 10, 2024 20:00
@gagank1
Copy link
Collaborator Author

gagank1 commented Dec 10, 2024

/build-ci

@gagank1 gagank1 merged commit 462f65e into main Dec 10, 2024
4 checks passed
@gagank1 gagank1 deleted the gkaushik/bionemo2-gh200 branch December 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants