Avoid searching unnecessary dirs for shared libs #1801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1788 changed the
.so
import logic to search multiple paths since the different build paths (editable builds, source builds, Pip wheels) might put the.so
s in different places. However, the current implementation is slow since it traverses the entire directory (including.git
). This PR fixes the search logic to only look at required paths.I've also modified the search logic to prioritize the imported TE module. If I manually set
PYTHONPATH
to point to my local install and it has everything it needs, why should we care at all about whatever is installed in the site-packages dir? I don't think this should affect correctness with the different build paths, but pinging @ksivaman.Type of change
Changes
.so
s..so
s in site-packages dir if not found in imported module.Checklist: