fix model parallel encoder to be properly sharded params #1794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Model parallel encoder example didn't shard params properly especially after #1772 changes which switches from direct mesh mapping of params (
flax.linen.partitioning.param_with_axes
) to logical mesh mapping of params (flax.linen.partitioning.with_logical_partitioning
).Also, even originally, the example didn't check after partitioning logic, whether the params are actually sharded on the devices. MaxText has way to test this so taking motivation from this API to verify sharding for the params in this example.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: