Skip to content

[PyTorch] Update PyTorch FSDP2 test to cover all TE layer types #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PyTorch] Update PyTorch FSDP2 test to cover all TE layer types #1777

wants to merge 5 commits into from

Conversation

denera
Copy link
Collaborator

@denera denera commented May 12, 2025 •
edited
Loading

Description

This PR expands the FSDP2 test to cover fused and composite layers.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@denera denera self-assigned this May 12, 2025
@denera denera added testing Improvements to tests or testing infrastructure 2.4.0 labels May 12, 2025
@denera
Copy link
Collaborator Author

denera commented May 12, 2025

/te-ci pytorch L1

@ksivaman
Copy link
Member

/te-ci pytorch L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngeunkwon0405 youngeunkwon0405 youngeunkwon0405 left review comments

@ksivaman ksivaman ksivaman approved these changes

Assignees

@denera denera

Labels
2.4.0 testing Improvements to tests or testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denera @ksivaman @youngeunkwon0405