-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propogate dp last changes from mcore #12012
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ryan Wolf <[email protected]>
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified:
Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: ryantwolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: ryantwolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: ryantwolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
What does this PR do ?
Adds support for DP-last in NeMo like in megatron core.
Collection: [Note which collection this PR will affect]
Changelog
tp-pp-dp
totp-cp-ep-pp-dp
inparallel_state.initialize_model_parallel
whenuse_tp_pp_dp_mapping
is specified.use_tp_pp_dp_mapping
toParallelismConfig
and ensures it is passed toMegatronStrategy
andFabricMegatronStrategy
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information