feat: default to UV_CACHE_DIR from within the container #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
terrykong
requested review from
yuki-666,
SahilJain314 and
parthchadha
and removed request for
yuki-666
terrykong
force-pushed
the
use-default-uvcache
branch
from
5aac48c to
4415e55
Compare
Signed-off-by: Terry Kong <[email protected]> fix it Signed-off-by: Terry Kong <[email protected]> make it match Signed-off-by: Terry Kong <[email protected]> fix it all Signed-off-by: Terry Kong <[email protected]>
terrykong
force-pushed
the
use-default-uvcache
branch
from
4415e55 to
c06ba88
Compare
Signed-off-by: Terry Kong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Our instructions for UV_CACHE_DIR are outdated. This PR updates them, but also defaults to using the UV_CACHE_DIR within the container. The old behavior is still supported via
UV_CACHE_DIR_OVERRIDE, but it saves disk space during experimentation not having to create multiple UV_CACHE_DIRs for each experiment.Will wait for #410 to go in since this doc change is based on that PRs doc change.
Issues
List issues that this PR closes (syntax):
Closes #426
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information