Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLM_HF example #3054

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Update LLM_HF example #3054

merged 12 commits into from
Nov 7, 2024

Conversation

ZiyueXu77
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 commented Oct 31, 2024 •
edited by holgerroth
Loading

Fixes # .

Description

Update LLM_HF example to use the latest Llama-3.2 model, update to comply with recent HF API changes.
Replace job template with JobAPI script.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@holgerroth
Copy link
Collaborator

Let's have a separate PR for LLM_HF update and compression filter.

@ZiyueXu77
Copy link
Collaborator Author

Let's have a separate PR for LLM_HF update and compression filter.

moved compression part out for the next PR

@holgerroth holgerroth changed the title Add message compress filter and update LLM_HF example Update LLM_HF example Nov 5, 2024
@holgerroth
Copy link
Collaborator

Let's have a separate PR for LLM_HF update and compression filter.

moved compression part out for the next PR

Thanks. I updated this PR title and description accordingly.

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) November 5, 2024 21:44
@ZiyueXu77
Copy link
Collaborator Author

/build

holgerroth
holgerroth approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks!

@ZiyueXu77 ZiyueXu77 merged commit 3f7b12b into NVIDIA:main Nov 7, 2024
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the compress_filter branch November 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @holgerroth