Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap the xgboost plugin into a C library. #2639

Merged
merged 9 commits into from
Jun 14, 2024
Merged

Wrap the xgboost plugin into a C library. #2639

merged 9 commits into from
Jun 14, 2024

Conversation

trivialfis
Copy link
Contributor

@trivialfis trivialfis commented Jun 12, 2024 •
edited
Loading

Description

See dmlc/xgboost#10410 for details.

Since it's wrapped into a C lib, tests are written in Python.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen chesterxgchen requested review from nvidianz, yanchengnv, YuanTingHsieh and ZiyueXu77 and removed request for nvidianz June 14, 2024 03:40
@trivialfis trivialfis changed the title [WIP] Wrap the xgboost plugin into a C library. Wrap the xgboost plugin into a C library. Jun 14, 2024
@trivialfis trivialfis marked this pull request as ready for review June 14, 2024 08:48
nvidianz
nvidianz approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will add my buffer size changes once merged.

@nvidianz nvidianz merged commit e7597e1 into NVIDIA:main Jun 14, 2024
15 checks passed
@trivialfis trivialfis deleted the fed-xgboost branch June 14, 2024 16:11
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@trivialfis @nvidianz
Wrap the xgboost plugin into a C library. (NVIDIA#2639)
c9f2c44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvidianz nvidianz nvidianz approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@ZiyueXu77 ZiyueXu77 Awaiting requested review from ZiyueXu77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @nvidianz