-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External test trigger #683
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, GitHub would turn `<img src="XXX">` into `<a href="XXX"><img src="XXX"></a>`.
terrykong
previously approved these changes
Apr 4, 2024
Documenting all JAX and XLA flags that we use for high performance LLMs with JAX/XLA. Will update this periodically, and also link to - https://github.com/google/jax/blob/main/docs/gpu_performance_tips.md Per Yu-Hang's suggestion, will update https://github.com/NVIDIA/JAX-Toolbox/blob/main/README.md#environment-variables to this page as well, once the PR is merged. --------- Co-authored-by: Abhinav Goel <[email protected]>
Fixes TE flash attention in maxtext's default model's `quantize_kvcache` config. This introduces a patch that is applied on top of upstream maxtext
yhtang
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the changeset include maxtext stuff? Is the branch based off main or 24.04-devel?
yhtang
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase it on top of 24.04-devel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_test_unit.yaml does not accept
IMAGE
as a parameter.