Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External test trigger #683

Closed
wants to merge 17 commits into from
Closed

External test trigger #683

wants to merge 17 commits into from

Conversation

DwarKapex
Copy link
Contributor

_test_unit.yaml does not accept IMAGE as a parameter.

@DwarKapex DwarKapex requested review from yhtang and terrykong April 4, 2024 16:52
terrykong
terrykong previously approved these changes Apr 4, 2024
instinct79 and others added 4 commits April 4, 2024 15:03
Documenting all JAX and XLA flags that we use for high performance LLMs
with JAX/XLA.

Will update this periodically, and also link to 
- https://github.com/google/jax/blob/main/docs/gpu_performance_tips.md

Per Yu-Hang's suggestion, will update
https://github.com/NVIDIA/JAX-Toolbox/blob/main/README.md#environment-variables
to this page as well, once the PR is merged.

---------

Co-authored-by: Abhinav Goel <[email protected]>
Fixes TE flash attention in maxtext's default model's `quantize_kvcache`
config. This introduces a patch that is applied on top of upstream
maxtext
Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the changeset include maxtext stuff? Is the branch based off main or 24.04-devel?

Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase it on top of 24.04-devel

@DwarKapex DwarKapex closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants