Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Tensor::index via Python API #3705

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Expose Tensor::index via Python API #3705

merged 2 commits into from
Jan 14, 2025
+7 −1

Conversation

wujingyue
Copy link
Collaborator

To be used in #3703

@wujingyue wujingyue requested a review from rdspring1 January 14, 2025 17:37
@wujingyue
Copy link
Collaborator Author

!test

rdspring1
rdspring1 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@rdspring1 rdspring1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a docstring?

Does Tensor::index return the tensor's integer index in the fusion definition?

I'm guessing you're trying to find a tensor during scheduling based on its index.

@wujingyue
Copy link
Collaborator Author

!build

@wujingyue
Copy link
Collaborator Author

Does Tensor::index return the tensor's integer index in the fusion definition?

Yes

I'm guessing you're trying to find a tensor during scheduling based on its index.

In #3703, I'm trying to find the input tensor by argument index. The solution so far is to find the tensor by index FusionDefinition.inputs[0]

@wujingyue wujingyue merged commit 3d27e10 into main Jan 14, 2025
17 checks passed
@wujingyue wujingyue deleted the wjy/index branch January 14, 2025 23:04
@wujingyue
Copy link
Collaborator Author

FYI, @syed-ahmed, I merged this to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdspring1 rdspring1 rdspring1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wujingyue @rdspring1