Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getRuleByRuleId returns clone rules and revisions related to ruleId #1536

Merged
merged 5 commits into from
Feb 21, 2025
Merged

feat: getRuleByRuleId returns clone rules and revisions related to ruleId #1536

merged 5 commits into from
Feb 21, 2025

Conversation

Matte22
Copy link
Collaborator

@Matte22 Matte22 commented Feb 19, 2025

resolves #1509

This PR introduced two new projections ["stigs", "ruleIds"] to GET /stigs/rules/{ruleId}

Schema:

  • getRuleByRuleId now accepts two new projections ["stigs", "ruleIds"]
  • getRuleByRuleId's response can now optionally include a ruleIds array and stigs array

API:

  • Code was added to handle two new projections ["stigs", "ruleIds"]

Tests:

  • Test were added to ensure correct functionality

@Matte22 Matte22 marked this pull request as draft February 19, 2025 23:38
@csmig csmig marked this pull request as ready for review February 20, 2025 15:17
@csmig csmig marked this pull request as draft February 20, 2025 19:38
@cd-rite cd-rite marked this pull request as ready for review February 20, 2025 22:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'nuwcdivnpt_stig-manager-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Matte22 Matte22 merged commit 48d24e5 into main Feb 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ruleIds and stigs projection to GET /stigs/rules/{ruleId}
3 participants
@Matte22 @csmig @cd-rite