Fix/student work metrics #199
Conversation
|
I got this when attempting to invite my other account as a student |
| totalCount := work.CommitAmount | ||
|
|
||
| // Zero either implies bad data or no commits, double check to be safe | ||
| if totalCount == 0 { |
There was a problem hiding this comment.
I like the thought behind this sanity check, but it doesn't seem like it does anything to fix the bad state once you recognize that there may be something wrong with the commit data.
There was a problem hiding this comment.
it updates it now!
backend/internal/handlers/classrooms/assignments/works/works.go
Outdated
Show resolved
Hide resolved
backend/internal/handlers/classrooms/assignments/works/works.go
Outdated
Show resolved
Hide resolved
|
Going into the mock data classroom Fall2025 and assignment Fall2025MockAssignment shows this where the student list and chart don't match up
|
|
the Spring2025 classroom also seems off. TAs and Professors should probably not be included in the chart data.
|
These are only due to assignments being accepted by professors and TAs before the safeguards were in place, this shouldn't be an issue any more |
|
I accepted an assignment and made a single commit and this is what the graph looks like. Having the same date two times on here is a little weird. |
|
|
||
| // Zero either implies bad data or no commits, double check to be safe | ||
| if totalCount == 0 { | ||
| fmt.Println("Needed to get from place") |
| fcd := work.FirstCommitDate | ||
|
|
||
| if fcd == nil { | ||
| fmt.Println("Needed to get from place") |
…ts/khoury-classroom-plugin into fix/student-work-metrics
Checklist