Feature/disallow invalid assignment names, join on assignment accept (KHO-311, KHO-242, KHO-310)

[ntietje1]

Summary

• Adds name validation to match github repository naming rules, disallowing special characters in classroom and assignment names
• Also adds a workaround for the "enable actions" button!!!

Checklist

• I have performed a self-review of my code
• I have reached out to another developer to review my code
• New and existing unit tests pass locally with my changes
• All Lint and CI checks are passing

[ntietje1]

Any assignment name with an ! or ~ seem to break things, not allowing users to accept it

I adjusted the validation to now disallow all special characters (on both the front and back ends)

[alexangione419]

assignment acceptance workflow seems broke, both first join class than accept, and accept first

backend | 2025/03/11 17:27:03 ERROR HTTP API error err="api error: 500 internal server error" method=POST path=/classrooms/classroom/0/assignments/token/a5274a1bbed86831ca74d89237264bbe
backend | [17:27:02] 172.19.0.1:52536 856 83447b24-a756-42f4-9e05-b2abab7cdef2 500 - 488.685294ms POST /classrooms/classroom/0/assignments/token/a5274a1bbed86831ca74d89237264bbe

I'm unsure how to reproduce this error, but while fiddling I got this
2025/03/11 17:21:07 ERROR HTTP API error err="PUT https://api.github.com/repos/NUSpecialProjects/Fall-2025-new-assignment-flow-type-beat/contents/.github/workflows/deadline-enforcement.yml: 422 Invalid request.\n\n"sha" wasn't supplied. []" method=POST path=/classrooms/classroom/0/assignments/token/671bcf7c4816db52815453e67679d232

[ntietje1]

assignment acceptance workflow seems broke, both first join class than accept, and accept first

backend | 2025/03/11 17:27:03 ERROR HTTP API error err="api error: 500 internal server error" method=POST path=/classrooms/classroom/0/assignments/token/a5274a1bbed86831ca74d89237264bbe backend | [17:27:02] 172.19.0.1:52536 856 83447b24-a756-42f4-9e05-b2abab7cdef2 500 - 488.685294ms POST /classrooms/classroom/0/assignments/token/a5274a1bbed86831ca74d89237264bbe

I'm unsure how to reproduce this error, but while fiddling I got this 2025/03/11 17:21:07 ERROR HTTP API error err="PUT https://api.github.com/repos/NUSpecialProjects/Fall-2025-new-assignment-flow-type-beat/contents/.github/workflows/deadline-enforcement.yml: 422 Invalid request.\n\n"sha" wasn't supplied. []" method=POST path=/classrooms/classroom/0/assignments/token/671bcf7c4816db52815453e67679d232

fixed in latest commit. There were two issues: one where the PR enforcement file already existed, which caused an error when we attempted to add that file again. Also, my unique repo name function did not properly work as the student does not have access to check what repos currently exist, so the github app must do that check. I'm not exactly sure why the mock data assignment/classroom specifically cause this, but whatever inconsistency exists is not a breaking issue for our app.

[Copilot]

Pull Request Overview

This PR introduces name validation for classroom and assignment names to disallow special characters and implements a workaround for the “enable actions” button. Key changes include:

• Adding a new repository name validation utility in the frontend to enforce GitHub repository naming rules.
• Updating classroom and assignment creation flows in the frontend to incorporate name validation and adjust error handling.
• Extending backend storage and GitHub client functionality to support new features such as fetching student work by GitHub user ID and repository initialization.

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
frontend/src/utils/repo-name-validation.ts	New utility to validate repository names by allowing only alphanumeric characters and hyphens.
frontend/src/pages/Classrooms/Create/index.tsx	Integrates name validation into classroom creation and updates error and button state logic accordingly.
frontend/src/pages/Assignments/CreateAssignment/index.tsx	Validates assignment names and trims whitespace; refactors template repository fetching.
backend/internal/storage/*	Adds new methods to retrieve and update records (e.g. GetWorkByGitHubUserID and UpdateBaseRepoInitialized).
backend/internal/handlers/, github/	Refactors webhook handling and GitHub client calls to use common shared functions and improve repository initialization.

Files not reviewed (1)

• backend/database/migrations/001_khouryclassroom.sql: Language not supported

Comments suppressed due to low confidence (1)

frontend/src/pages/Classrooms/Create/index.tsx:27

• [nitpick] The variable name 'containsInvalidChars' is misleading since the validateRepoName function returns true for valid names. Consider renaming it to 'isValidRepoName' to more clearly indicate its purpose.

const containsInvalidChars = validateRepoName(name);

[alexangione419]

wonderful. see KHO-327 for work relating to this PR but not on this scope