-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Validation #210 #238
Open
noahseethorcodes
wants to merge
8
commits into
summer24-dev
Choose a base branch
from
bugs/noah/210
base: summer24-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Form Validation #210 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can try using react hook forms |
…ustom Error Handling for edge cases
…it to the rest of RHF's form state
nathantew14
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference my push to the branch and use the same method to turn the photo input intro a controlled input so that we don't have to use the customFormValidationState
nathantew14
added
on hold
Acknowledged but will not be worked on for now
awaiting changes
PR reviewed but needs changes
and removed
on hold
Acknowledged but will not be worked on for now
labels
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registration Form Validation Implementation. Initial implementation of form validation for forms on the site. Also fixed minor bug where village prefix wouldn't stick after closing the modal for the registration form. Removed toasts as I felt it made it too visually cluttered.
If this implementation of form validation is approved I will move on to implement it for the rest of the forms.