Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation #210 #238

Open
wants to merge 8 commits into
base: summer24-dev
Choose a base branch
from
Open

Form Validation #210 #238

wants to merge 8 commits into from

Conversation

noahseethorcodes
Copy link

@noahseethorcodes noahseethorcodes commented Oct 2, 2024

Registration Form Validation Implementation. Initial implementation of form validation for forms on the site. Also fixed minor bug where village prefix wouldn't stick after closing the modal for the registration form. Removed toasts as I felt it made it too visually cluttered.

If this implementation of form validation is approved I will move on to implement it for the rest of the forms.

@nathantew14
Copy link

can try using react hook forms

Copy link

@nathantew14 nathantew14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference my push to the branch and use the same method to turn the photo input intro a controlled input so that we don't have to use the customFormValidationState

@nathantew14 nathantew14 added on hold Acknowledged but will not be worked on for now awaiting changes PR reviewed but needs changes and removed on hold Acknowledged but will not be worked on for now labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes PR reviewed but needs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants