Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap dequeue and push #130

Merged
merged 6 commits into from
May 15, 2024
Merged

swap dequeue and push #130

merged 6 commits into from
May 15, 2024

Conversation

jdonszelmann
Copy link
Collaborator

@jdonszelmann jdonszelmann commented Sep 27, 2023

Fixes part of #129

@github-actions github-actions bot temporarily deployed to commit September 27, 2023 08:05 Inactive
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

@github-actions github-actions bot temporarily deployed to pull request September 27, 2023 08:05 Inactive
Copy link
Contributor

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

fn enqueue(&mut self, value: T) {
self.push(value);
/// Alias for [`enqueue`](RingBuffer::enqueue)
fn push(&mut self, value: T) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be marked deprecated?

@github-actions github-actions bot temporarily deployed to commit May 15, 2024 17:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 17:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 18:59 Inactive
@github-actions github-actions bot temporarily deployed to commit May 15, 2024 18:59 Inactive
@github-actions github-actions bot temporarily deployed to commit May 15, 2024 19:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 19:13 Inactive
@github-actions github-actions bot temporarily deployed to commit May 15, 2024 19:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2024 19:19 Inactive
@NULLx76 NULLx76 merged commit 137f388 into main May 15, 2024
18 checks passed
@NULLx76 NULLx76 deleted the swap_enqueue_push branch May 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants