Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API in Suitcase #62

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update API in Suitcase #62

wants to merge 6 commits into from

Conversation

licode
Copy link

@licode licode commented Apr 26, 2017

Some thoughts on how to do preprocessing on the data. Thanks for suggestion from @tacaswell

@licode
Copy link
Author

licode commented Apr 26, 2017

@stuartcampbell

@hhslepicka
Copy link

@licode, since we create the data broker with mds, fs can we just use the db instance at the export function?

@licode
Copy link
Author

licode commented Apr 26, 2017

Now we may have multiple databrokers, so it is better to define it explicitly as an input. But it is better to pass in db instead of db.mds in case we want to use other functions from db.

@hhslepicka
Copy link

Exactly! =)

@danielballan
Copy link
Contributor

@licode Did this code get ported to the suitcase repo?

@licode
Copy link
Author

licode commented May 22, 2017

right, this is the doc for a new PR in suitcase. I will do rebasing here.

@danielballan
Copy link
Contributor

What's the status of this? Is this still relevant given our new plans for suitcase, @licode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants