close shutter at end of run #6
Conversation
|
@DanOlds This needs testing |
|
Assigning lambdas to variables is discouraged. Even monkey-patching a proper |
|
I was hoping to test this first and then make it prettier, since I'd like to make certain that the fix will work. |
|
That's fair. I worry about the next person wondering, "Why is this |
|
My bigger problem is that we haven't declared what open and close are for set, so I'm guessing that 1 is closed. |
|
I see. Maybe it's worth setting up a caproto IOC that exposes one shutter PV with the enum states "Open" and "Closed" and then does the mapping to 0 or 1 internally. |
|
I'm not sure when the fix went in to PDF, but when I tested it yesterday
morning, the fast shutter did not automatically close on xrun.abort().
…On Thu, Mar 7, 2019 at 5:25 PM Dan Allan ***@***.***> wrote:
I see. Maybe it's worth setting up a caproto IOC that exposes one shutter
PV with the enum states "Open" and "Closed" and then does the mapping to 0
or 1 internally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMQJYXKISkPt6reUO31Gl2uIqAleV_A6ks5vUZHsgaJpZM4bbP6X>
.
--
Daniel Olds
Phone : 517-282-8009
|
|
It hasn't gone in, this is the PR proposing the fix. It needs to be accepted pulled down to the local machine and tested. |
|
@DanOlds in the git remote add CJ-Wright https://github.com/CJ-Wright/profile_collection.git
git fetch CJ-Wright
git checkout auto_closeThen you can run the test of the shutter action. |
|
I will test this when the users are not actively acquiring data.
…On Tue, Mar 12, 2019 at 11:05 AM Christopher J. Wright < ***@***.***> wrote:
@DanOlds <https://github.com/DanOlds> in the .ipython/profile_collection
directory run the following commands to get this branch
git remote add CJ-Wright https://github.com/CJ-Wright/profile_collection.git
git fetch CJ-Wright
git checkout auto_close
Then you can run the test of the shutter action.
Once you are done you can use git checkout <name of previous branch>
(hint: it is most likely stage_jank) to return to your previously state.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMQJYR62e1iO9XyLpBo3jFTmRiQMOmcgks5vV8IsgaJpZM4bbP6X>
.
--
Daniel Olds
Phone : 517-282-8009
|
|
@DanOlds I think this is ready for review/merge |
|
@DanOlds I think this is ready for review/merge |
No description provided.