Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting #6

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add linting #6

wants to merge 13 commits into from

Commits on Jul 29, 2022

  1. Add files for linting 

     * flake8, black, isort
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    8a6bb61 View commit details
    Browse the repository at this point in the history

  2. changes made by 'pre-commit run --all-files' 

     * do flake8 separately because it only reports errors, does not
   actually change files
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    26e8dcb View commit details
    Browse the repository at this point in the history

  3. initial commit of flake8 fixes 

     * still have some variable issues to verify
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    bda3049 View commit details
    Browse the repository at this point in the history

  4. ignore flake8 E203 

     * prevent conflicts with black in handling spaces around array slicing
   with ":"
 * see pre-commit/pre-commit-hooks#112 comment
   from April 28, 2016 by dwaynebailey for where I saw this
   configuration method used
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    24885b0 View commit details
    Browse the repository at this point in the history

  5. remove unused import - flake8

    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    c9b1926 View commit details
    Browse the repository at this point in the history

  6. break up flake8-problem long lines manually

    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    46da6a3 View commit details
    Browse the repository at this point in the history

  7. add W503 

     * resolve the conflict between flake8 and black, which follows the
   anti-pattern described here https://www.flake8rules.com/rules/W503.html
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    6fa9e19 View commit details
    Browse the repository at this point in the history

  8. remove unused load_scan

    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ff6698b View commit details
    Browse the repository at this point in the history

  9. remove unused file 

     * after all code moved into tasks
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    efe1bce View commit details
    Browse the repository at this point in the history

  10. remove unused function

    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    4962e7d View commit details
    Browse the repository at this point in the history

  11. remove unused variable

    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    b590cd5 View commit details
    Browse the repository at this point in the history

  12. fix variable name 

     * looking back at the beamline profile_collection, the tomography
   images are to be used here
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    31e0a29 View commit details
    Browse the repository at this point in the history

  13. fix E741 by renaming 

     * use "ell" instead of the lowercase letter "l" to prevent possible
   mis-reading (as capital I, for instance)
    @JunAishima
    JunAishima committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    c1235e2 View commit details
    Browse the repository at this point in the history