ENH: multi stream help #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The huge diff in https://github.com/NSLS-II-FXI/profile_collection/pull/3/files#diff-87e76dd09be85349d2409d8fdd9695e9 is due to the reformatting done with https://github.com/psf/black. |
This may require a newer version of ohpyd, may have to vendor a helper function to get the dotted_name functionality
Do not assume each point as the same number of frames, requires changes to the schema of the resource and datum + a new handler.
tacaswell
force-pushed
the
enh_mulit_stream_help
branch
from
4b5387e to
ee1e759
Compare
This produced an off-by-one issue that shifted all of the data access back by one
|
I don't think this should be merged until we get bluesky/area-detector-handlers#11 merged as this is radically changing how we are diving up the data set in the hdf5 file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref bluesky/area-detector-handlers#11.