Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreal #23

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Unreal #23

wants to merge 6 commits into from

Conversation

mguercio626
Copy link

Unreal engine edits.

@bruceravel
Copy link
Member

bruceravel commented Jul 25, 2023 •
edited
Loading

@mguercio626, @gwbischof, I am thinking that I would prefer to use an environment variable -- say $BLUESKY_UNREAL -- and use os.getenv() to fetch its value. That seems more maintainable and usable than a hard-coded switch (which is repeated several times in different places).

bruceravel
bruceravel reviewed Jul 25, 2023
View reviewed changes
startup/BMM/unreal_mono.py
kind="hinted")


a = A(name='dcm')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for? I am not seeing where this object is used. Also, a and A are way too short/non-specific for object names in production code.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this file. We were just using it for testing.

bruceravel
bruceravel reviewed Jul 25, 2023
View reviewed changes
startup/BMM/motors.py
@@ -436,7 +436,7 @@ class VacuumEpicsMotor(FMBOEpicsMotor):

def set(self, position, **kwargs):
self.kill_cmd.put(1)
return super().set(position, **kwargs)
return super().est(position, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est??? That cannot be right....

@gwbischof
Copy link

@mguercio626, @gwbischof, I am thinking that I would prefer to use an environment variable -- say $BLUESKY_UNREAL -- and use os.getenv() to fetch its value. That seems more maintainable and usable than a hard-coded switch (which is repeated several times in different places).

Sounds good, that's what we were thinking too.

@gwbischof
Copy link

We made a bluesky-unreal package here: https://github.com/gwbischof/bluesky-unreal/tree/main/bluesky_unreal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbischof gwbischof gwbischof left review comments

@bruceravel bruceravel bruceravel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguercio626 @bruceravel @gwbischof