Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Coulombic efficiency #4

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Working Coulombic efficiency #4

merged 2 commits into from
Dec 9, 2024

Conversation

c-randall
Copy link
Collaborator

Description

This PR adds Coulombic efficiency to the model. Users must now specify ce as an input parameter. The Coulombic efficiency only affects how the soc evolves in time during charging:

ce = 1. if current >= 0. else model.ce
dsoc_dt = -ce*current / 3600. / model.capacity

Resolves #3

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that improves speed/readability/etc.)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ nox -s linter [-- format]
  • Code is free of misspellings: $ nox -s codespell [-- write]
  • All tests pass: $ nox -s tests
  • Badges are updated: $ nox -s badges

The optional -- format and -- write arguments (see above) attempt to correct formatting issues prior to running the linter, and spelling mistakes prior to running the spellcheck, respectively. You can also run all of the above checks using $ nox -s pre-commit instead of running them individually.

Further checks:

  • The documentation builds: $ nox -s docs.
  • Code is commented, particularly in hard-to-understand areas.
  • Tests are added that prove fix is effective or that feature works.

@c-randall c-randall marked this pull request as ready for review December 9, 2024 21:09
@c-randall c-randall merged commit e4f3b9c into main Dec 9, 2024
9 checks passed
@c-randall c-randall deleted the add-coulombic branch December 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Coulombic efficiency
1 participant