Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Coulombic efficiency to the model. Users must now specify
ce
as an input parameter. The Coulombic efficiency only affects how thesoc
evolves in time during charging:Resolves #3
Type of change
Key checklist:
$ nox -s linter [-- format]
$ nox -s codespell [-- write]
$ nox -s tests
$ nox -s badges
The optional
-- format
and-- write
arguments (see above) attempt to correct formatting issues prior to running the linter, and spelling mistakes prior to running the spellcheck, respectively. You can also run all of the above checks using$ nox -s pre-commit
instead of running them individually.Further checks:
$ nox -s docs
.