Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bifacial option in Mermoud Lejeune module model #622

Merged

Conversation

allenlawrence94
Copy link
Contributor

Issue: #241

I cherry-picked the commit that exposes a bifacial option from @caseyzak24's PR #314, added a test, and fixed a couple bugs.

More detail on the bugs:

  • There was no calculation of nominal module efficiency in the Mermoud case, which created nonsense results for nominal dc energy and performance ratio when using the Mermoud model.
  • IAM would evaluate to nan when front-side irradiance was 0. It seems sunup should prevent the pv model from running when irradiance is 0, but it still happens occasionally (in the new test case it occurs in 112 shoulder hours in the year). Is this okay?

@janinefreeman
Copy link
Collaborator

@allenlawrence94 Thank you so much, this is great! I will be merging this in for our upcoming release! We super appreciate the contribution.

@allenlawrence94
Copy link
Contributor Author

Awesome! Thanks janine

@janinefreeman janinefreeman merged commit ae16711 into NREL:develop Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants