Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssc 1123 price signals to retail rate naming #1064

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Oct 11, 2023

Rename price signals dispatch to retail rate dispatch, bringing the old "forecast" enum along the way.

Fixes NREL/SAM#1123

Companion SAM PR:

Should be good to go if the tests pass, but any additional searches for "price signals" as a spot check would be appreciated.

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Pointing out some additional variables, not sure if these need changing.

  • "Price signal" in comment of lib_utility_rate.cpp:

    // Ignore any peak charges lower than the average gross load - this prevents the price signal from showing demand charges on the first hour of each month when the load is not really a peak

  • Also forecast_price_series_dollar_per_kwh in cmod_battery.cpp/h is for FOM battery, but I think refers to retail rates for electricity purchases,

    forecast_price_signal fps(&vt);

  • forecast_price_signal class in common.h

  • vtab_forecast_price-signal in cmod_pvsamv1.cpp

@brtietz
Copy link
Collaborator Author

brtietz commented Oct 16, 2023

@cpaulgilman Thanks! I clarified that first comment to "retail rate forecast." The other three variables are for the front of meter automated dispatch, so I'll leave those alone.

@brtietz brtietz merged commit 49524b4 into develop Oct 16, 2023
4 checks passed
@brtietz brtietz deleted the ssc_1123_price_signals_to_retail_rate_naming branch October 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Price Signals Dispatch to Utility Rate Dispatch
2 participants