-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Consolidate code structure #26
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 93.97% 90.14% -3.84%
==========================================
Files 7 9 +2
Lines 880 1552 +672
==========================================
+ Hits 827 1399 +572
- Misses 53 153 +100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cursor.execute(query_string) | ||
|
||
return cursor.fetchall() | ||
except sqlite3.Error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This except clause is a no-op.
a17a29d
to
abd4aad
Compare
Code Structure Changes
api.py
andsqlite.py
to plexosdb.py and db_manager.py.plexosdb.py
includes only the API to the application, e.g., get_object, add_object anddb_manager
the API to SQLite only.PlexosDB
from_xml() for easier instantiation from an XML file,Remaining methods to migrate