Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Webrick #99

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add Webrick #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ else
end

gem 'byebug', '~> 11.1.3'
gem 'webrick', '~> 1.8.2'
Copy link
Collaborator

@jmarrec jmarrec Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webrick doesn't have a C extension, and we're not patching it whatsoever, so why not just do spec.add_dependency 'webrick', '~> 1.8.2' in openstudio-gems.gemspec instead?

here:

openstudio-gems/openstudio-gems.gemspec

Line 25 in 732fe79

spec.add_dependency 'parallel', '1.19.1'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbenne


# leave this line in for now as we may try to get nokogiri to compile correctly on windows
# gem 'nokogiri', '= 1.11.0.rc1.20200331222433', :github => 'jmarrec/nokogiri', :ref => 'MSVC_support' # master of 2020-03-31 + gemspec commit
Loading