adding new from_github vehicle method #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calbaker
reviewed
Dec 21, 2023
calbaker
reviewed
Dec 21, 2023
calbaker
reviewed
Dec 21, 2023
calbaker
reviewed
Dec 21, 2023
calbaker
reviewed
Dec 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
calbaker
reviewed
Dec 21, 2023
kylecarow
reviewed
Jan 3, 2024
| } | ||
| Ok(vehicle_name_list) | ||
| } | ||
|
|
kylecarow
reviewed
Feb 1, 2024
Comment on lines
+1843
to
+1847
| let url = &object.url; | ||
| let vehicle_name_sublist = fetch_github_list(Some(url.to_owned()))?; | ||
| for name in vehicle_name_sublist.iter() { | ||
| vehicle_name_list.push(name.to_owned()); | ||
| } |
There was a problem hiding this comment.
@robinsteuteville Would this only look one level deep into directories?
There was a problem hiding this comment.
@kylecarow I believe it should look as many levels deep into directories as needed, since it calls fetch_github_list recursively within itself, which should mean that each time it comes across a subdirectory within the current directory it is in, it should start the process over again for that subdirectory, which in turn will uncover any subsubdirectories, etc. Does make my brain hurt a bit, so if you see a problem within the recursive logic let me know, I definitely could be thinking about it wrong!
calbaker
reviewed
Feb 6, 2024
| @@ -39,6 +39,9 @@ include_dir = "0.7.3" | |||
| itertools = "0.12.0" | |||
| ndarray-stats = "0.5.1" | |||
| tempfile = "3.8.1" | |||
| url = "2.5.0" | |||
There was a problem hiding this comment.
@kylecarow, could you feature gate this stuff?
calbaker
reviewed
Feb 6, 2024
kylecarow
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.