F3/thermal #175
Merged
F3/thermal #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next step: battery thermal model and HVAC controls
Controls still need work. all tests pass
working on ReversibleEnergyStorage thermal controls moved HVAC to own module
left `todo!()` to jog memory about where to resume work
then make demos and re-merge after that but first, troubleshoot compiler errors
doc cleanup
all thermal models are hypothetically correctly implemented!
|
@michael-okeefe, I don't see Windows in here at all: any ideas? |
|
@michael-okeefe please disregard the previous messsage. There was a hidden scroll bar! Hahhahah, my bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thermal models are hypothetically fully and correctly implemented. There will be another PR with this branch finishing out the tasks in https://github.nrel.gov/MBAP/fastsim/issues/379.