Fix issues with release.yaml due to breaking changes in actions/upload-artifact and actions/download-artifact #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions/upload-artifact and actions/download-artifact both were updated with breaking changes which caused release.yaml not to run anymore. This attempts to fix the release mechanism to working order again. Key change is that upload-artifact must now use unique names and dowload-artifact must be changed to merge all files into a single directory for twine to pick up.
Apple silicon builds have a requirement for a recent pip.
|
@calbaker @kylecarow I've gotten the Would you both be OK with me setting up separate Apple Silicon and Apple Intel builds? Or do you have any thoughts on how to get a universal build working on cibuildwheel for Apple? See here if you'd like to look at the latest build errors: https://github.com/NREL/fastsim/actions/runs/12246134820/job/34161446298 |
added 5 commits
December 11, 2024 14:37
Attempt to use separate intel and apple silicon builds vs trying to use the universal build for wheels. This is faciliated by using macos-13 (Intel) and macos-14 (Apple Silicon).
The variable 'MACOSX_DEPLOYMENT_TARGET=10.12' is needed to updated minimum supported macOS for this wheel.
|
Note: release is running clean (this version has the pypi deploy disabled): |
|
@michael-okeefe, could you investigate the failing checks in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/upload-artifactandactions/download-artifactboth were updated with breaking changes which caused release.yaml not to run anymore. (NOTE: there were deprecations so keeping with the old version was not an option). This attempts to fix the release mechanism to working order again.Key change is that upload-artifact must now use unique names and dowload-artifact must be changed to merge all files into a single directory for twine to pick up.
v2.1.3+mod01)References: