Skip to content

Commit

Permalink
Add note for os matrix
Browse files Browse the repository at this point in the history
The Mac OS options might be hard for others to follow. Here, we add a note to help others following behind to understand what we're doing and why.
  • Loading branch information
michael-okeefe authored Dec 9, 2024
1 parent ef074a6 commit 83e16d4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ jobs:
name: build py3.${{ matrix.python-version }} on ${{ matrix.platform || matrix.os.base }}-${{ matrix.os.version }}
strategy:
fail-fast: true
# NOTE: In the matrix below, we call out macos 13 and 14 explicitly. This is to enable running on both Intel and Apple Silicon for Mac.
# As of this writing, MacOS 13 is Intel and MacOS 14 is Apple Silicon. Ideally, the Apple transition to their new chip occurs fast and
# we can drop macos-13 checks and then just use 'latest'.
matrix:
os:
- base: ubuntu
Expand Down

0 comments on commit 83e16d4

Please sign in to comment.