Skip to content

Commit

Permalink
Skipping speed tests.
Browse files Browse the repository at this point in the history
These did not consistently pass on the CI.

From Chad Baker:
... the speedup failing tests can be ignored for now.
We need to come up with a better way of testing the speed
up relative to fastsim-2, but I’m not sure that's an
urgent problem.
  • Loading branch information
Michael O'Keefe authored and Michael O'Keefe committed Nov 14, 2024
1 parent f0a45a3 commit 4abf4a9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions python/fastsim/tests/test_speedup.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import time
import numpy as np
import fastsim as fsim
import pytest

n_iters = 5

@pytest.mark.skip(reason = "Ignoring for now")
def test_hev_speedup():
# minimum allowed f3 / f2 speed ratio
min_speed_ratio_si_none = 2
Expand Down Expand Up @@ -71,6 +73,7 @@ def test_hev_speedup():
assert t_fsim2_median / t_fsim3_no_save_median > min_speed_ratio_si_none, \
f"`min_speed_ratio_si_none`: {min_speed_ratio_si_none:.3G}, median achieved ratio: {(t_fsim2_median / t_fsim3_no_save_median):.3G}"

@pytest.mark.skip(reason = "Ignoring for now")
def test_conv_speedup():
# minimum allowed f3 / f2 speed ratio
# there is some wiggle room on these but we're trying to get 10x speedup
Expand Down

0 comments on commit 4abf4a9

Please sign in to comment.