Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost ready to be merged - one test still fails and is expected to (further information below). Further updates are potentially needed to the example scripts.
Feature or improvement description
Updated the modeling schema for PEM_cell to remove hard-coded model parameters such as electrode pressures, membrane thickness, faradaic coefficients, and removed dryer losses.
Impacted areas of the software
primary updates to PEM_cell.py and modeling_schema.yaml. Relevant tests were also updated.
Additional supporting information
Primary PEM cell modeling parameters and operational conditions that were previously hard-coded are now included in the input file. Previous hard-coded modeling parameters are now the default values in modeling_schema.yaml.
Test results, if applicable