Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HES Workflow Generator, try 2 #378

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

HES Workflow Generator, try 2 #378

wants to merge 15 commits into from

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Jul 7, 2023

Pull Request Description

This ports over the changes from #252 into a later version of buildstockbatch, replacing that PR.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket changed the base branch from develop to os380 May 14, 2024 15:53
Base automatically changed from os380 to develop May 16, 2024 17:53
@nmerket
Copy link
Member Author

nmerket commented Jul 12, 2024

@rajeee I'm a little lost on what happened with the refactor in #456. I just tried to pull in the latest from develop and am having trouble. In this PR, I have a workflow generator that inserts the argument os_hescore_directory into BuildExistingModel. I used to just put it in the workflow arguments in the yaml, but that doesn't seem to be working now. What's the right way to go about that at this point?

@rajeee
Copy link
Contributor

rajeee commented Jul 12, 2024

@rajeee I'm a little lost on what happened with the refactor in #456. I just tried to pull in the latest from develop and am having trouble. In this PR, I have a workflow generator that inserts the argument os_hescore_directory into BuildExistingModel. I used to just put it in the workflow arguments in the yaml, but that doesn't seem to be working now. What's the right way to go about that at this point?

Looks like I introduced a bug in that PR that wasn't caught by the test.
This line causes crash if you don't have BuildExistingKey already present. Bug fix would be to check if that key exists first, and if not, initialize with empty dict.

@rajeee rajeee mentioned this pull request Jul 15, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants