Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ll/test merge period begin #339

Open
wants to merge 3 commits into
base: period_begin
Choose a base branch
from

Conversation

lixiliu
Copy link
Contributor

@lixiliu lixiliu commented Jan 9, 2023

Merge PR #324 into period_begin branch

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run to make sure it all works (local is fine, unless an Eagle specific feature)
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@lixiliu lixiliu requested a review from whiphi92 January 9, 2023 19:27
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

File Coverage
All files 80%
base.py 80%
eagle.py 74%
exc.py 57%
localdocker.py 27%
postprocessing.py 84%
utils.py 96%
sampler/base.py 69%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 50%
test/test_validation.py 96%
workflow_generator/base.py 90%
workflow_generator/commercial.py 24%
workflow_generator/residential.py 96%
workflow_generator/residential_hpxml.py 59%

Minimum allowed coverage is 24%

Generated by 🐒 cobertura-action against 978cdc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants