Multi scene objs #487
Merged
Multi scene objs #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch extracts scene.radfiles from each scene in the list. Tests are passing
…j.appendtoScene. Update runs of tutorials 7 and 19, which are working.
…l tests are passing, still need modelchain updates..
…bug fixed. tests fixed, new functionality tested in test_1axis_gencumSky
|
Moved over to PR #488 |
|
OK, nevermind, we'll work on this branch to make it easier. Closing #488 |
…diance into multi_sceneObjs
…ch extracts scene.radfiles from each scene in the list. Tests are passing
…j.appendtoScene. Update runs of tutorials 7 and 19, which are working.
…l tests are passing, still need modelchain updates..
…bug fixed. tests fixed, new functionality tested in test_1axis_gencumSky
…diance into multi_sceneObjs
|
calculateResults() failing with multi scene and multi result objects... |
…rdict. Add sceneNum to CompiledResults.
…ulative_results, not trackerdict.
|
backseat driving --- there is an option of AgriPV = True which basically bypasses calculating module results (I think it might also look at only 1 single csv result front or back, I don't recall), but it was also not working with multi result/object |
…2 &3. - remove trackerdict['Results']. New functions in AnalysisObj: calc_performance and getResults. new parameter: power_data
…m trackerdict. remove 'analysisObj' return value from runModelChain
Results refactor
|
Tests are passing, just a coveralls error. This is ready to merge with development. We can update journals from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple scene objects to be tracked at the same time by the RadianceObj. This is accomplished by running makeScene multiple times, each one appends a new SceneObj to RadianceObj.scenes which is a new list to track scene objects.
todo:
CompileResult is hardcoded to run once over all sceneNums, even if bifacial modules and details are different.(will be handled in new PR tied to Performance analysis with multiple scenes #512 )Functionality to pop scenes from trackerdict if desired. This may mess up some naming, for instance if we have Scene0, Scene1, Scene2 and Scene1 gets popped. May require renaming the remaining scenes...In modelchain, sceneNum is hardwired to 0 in simulationParamsDict.get('saveImage') (line 253 of modelchain)(OK as-is...)Warning for tracker gencumsky if you have multiple scenes - the trackers need to have the same angles at the same times. Otherwise skyfiles will need to be created specific to the scene...New functions added to__init__.py