Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to openstudio 3.8, e+ 24.1 and pyfmi 2.11 #491

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

TShapinsky
Copy link
Member

No description provided.

@TShapinsky
Copy link
Member Author

@anyaelena @kbenne This should be pretty much good. Everything works now. Once the official release of 3.8 is released we can swap that in with this and then merge it into develop

@TShapinsky TShapinsky marked this pull request as ready for review May 10, 2024 16:44
@TShapinsky
Copy link
Member Author

@anyaelena @kbenne This branch is up to date with the release of OpenStudio 3.8. When we're ready I can do a new release of the alfalfa dependencies and then merge this in here.

@@ -1,5 +1,5 @@
# *******************************************************************************
# OpenStudio(R), Copyright (c) 2008-2022, Alliance for Sustainable Energy, LLC.
# OpenStudio(R), Copyright (c) 2008-2020, Alliance for Sustainable Energy, LLC.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a real diff. I created this new measure and deleted old unsused code. Git somehow thought that is a move and a giant edit

@anyaelena anyaelena self-requested a review June 19, 2024 01:15
anyaelena
anyaelena previously approved these changes Jun 19, 2024
Copy link
Member

@anyaelena anyaelena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed today. Thanks Toby!

@TShapinsky TShapinsky merged commit ea141e2 into develop Jun 20, 2024
6 checks passed
@TShapinsky TShapinsky deleted the openstudio_38 branch June 20, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants