Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Torch #323

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Update Torch #323

merged 2 commits into from
Jul 24, 2024

Conversation

haneslinger
Copy link
Collaborator

No description provided.

smithcommajoseph
smithcommajoseph approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@smithcommajoseph smithcommajoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all tests pass and I've confirmed torch v2 works with exploratory notebooks as well.

While not strictly necessary, I wonder if we should also regen the poetry.lock file as part of this update?

@haneslinger
Copy link
Collaborator Author

I think it shoudl be regened, isn't it already?

@smithcommajoseph
Copy link
Collaborator

Oh, yes it is! I missed it in the GitHubUI, but saw it locally. DERP!

@haneslinger haneslinger merged commit e7fea12 into develop Jul 24, 2024
2 checks passed
haneslinger added a commit that referenced this pull request Oct 9, 2024
@haneslinger
Update Torch (#323)
9503b01 
* Update Torch

* Fix version
https://stackoverflow.com/questions/76327419/valueerror-libcublas-so-0-9-not-found-in-the-system-path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithcommajoseph smithcommajoseph smithcommajoseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haneslinger @smithcommajoseph