Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sam 1632 crit load #1640

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Sam 1632 crit load #1640

merged 3 commits into from
Dec 6, 2023

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 6, 2023 •
edited
Loading

Pull Request Template

Description

Update crit load defaults and load mimo to include hybrids as crit load/grid outage techs

Fixes # #1632

Pairs with SSC pr NREL/ssc#1100

To test:

  1. Open a hybrids host-developer case
  2. Assign crit load to a percentage of load
  3. Assign some steps to a grid outage
  4. Run the case
  5. Crit load metrics are computed with the appropriate crit load (testable from the time series or data tables pages)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@brtietz brtietz added the dev bug Internal bug that should not be included in release notes label Dec 6, 2023
@brtietz brtietz added this to the SAM Fall 2023 Release milestone Dec 6, 2023
@brtietz brtietz self-assigned this Dec 6, 2023
@brtietz brtietz mentioned this pull request Dec 6, 2023
Merged
cpaulgilman
cpaulgilman approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulation runs with critical load and grid outage, and time series grid outage outputs look reasonable.

@brtietz brtietz merged commit 6eb3749 into develop Dec 6, 2023
4 checks passed
@brtietz brtietz deleted the sam_1632_crit_load branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@sjanzou sjanzou Awaiting requested review from sjanzou

Assignees

@brtietz brtietz

Labels
dev bug Internal bug that should not be included in release notes
Projects
None yet
Milestone
SAM Fall 2023 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brtietz @cpaulgilman